Skip to content

Commit

Permalink
Rerender specifically subtitle iff it's the only changed attribute.
Browse files Browse the repository at this point in the history
  • Loading branch information
dannon committed Apr 5, 2017
1 parent 2ab68fe commit 9e9a2d8
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 10 deletions.
5 changes: 4 additions & 1 deletion client/galaxy/scripts/mvc/dataset/dataset-li.js
Expand Up @@ -59,7 +59,10 @@ var DatasetListItemView = _super.extend(
.done( function(){ self.render(); });

} else {
if( _.has( model.changed, 'tags' ) ){
if( _.has( model.changed, 'tags' ) && _.keys( model.changed ).length === 1 ){
// If only the tags have changed, rerender specifically
// the titlebar region. Otherwise default to the full
// render.
this.$( '> .title-bar' ).replaceWith( this._renderTitleBar() );
} else {
self.render();
Expand Down
2 changes: 1 addition & 1 deletion static/maps/mvc/dataset/dataset-li.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions static/scripts/bundled/analysis.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/analysis.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/libs.bundled.js.map

Large diffs are not rendered by default.

0 comments on commit 9e9a2d8

Please sign in to comment.