Selenium - cleanup duplication of DEFAULT_PASSWORD variable.

galaxyproject · Oct 2, 2017 · afaea96 · afaea96
1 parent 28c8644
commit afaea96
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/test/selenium_tests/framework.py b/test/selenium_tests/framework.py
@@ -49,9 +49,6 @@
 # Auto-retry selenium tests this many times.
 GALAXY_TEST_SELENIUM_RETRIES = int(os.environ.get("GALAXY_TEST_SELENIUM_RETRIES", "0"))
 
-# Test case data
-DEFAULT_PASSWORD = '123456'
-
 
 try:
     from nose.tools import nottest

diff --git a/test/selenium_tests/test_registration.py b/test/selenium_tests/test_registration.py
@@ -1,5 +1,4 @@
 from .framework import (
-    DEFAULT_PASSWORD,
     selenium_test,
     SeleniumTestCase
 )
@@ -33,7 +32,7 @@ def test_logout(self):
     def test_reregister_email_fails(self):
         self.home()
         email = self._get_random_email()
-        password = DEFAULT_PASSWORD
+        password = self.default_password
         confirm = password
         username = email.split("@")[0]
         self.register(email, password, username, confirm)
@@ -47,7 +46,7 @@ def test_reregister_username_fails(self):
         self.home()
         email1 = self._get_random_email()
         email2 = self._get_random_email()
-        password = DEFAULT_PASSWORD
+        password = self.default_password
         confirm = password
         username = email1.split("@")[0]
         self.register(email1, password, username, confirm)
@@ -60,7 +59,7 @@ def test_reregister_username_fails(self):
     def test_bad_emails(self):
         bad_emails = ['bob', 'bob@', 'bob@idontwanttocleanup', 'bob.cantmakeme']
         good_email = self._get_random_email()
-        password = DEFAULT_PASSWORD
+        password = self.default_password
         confirm = password
         username = good_email.split("@")[0]