Skip to content

Commit

Permalink
Fix for server error when installing some repos.
Browse files Browse the repository at this point in the history
Examples: IUC's gatk2 repository, devteam's samtools_rmdup.

When attempting to install either of those, or another repository
that has tool tests with an input parameter that does not have a
value attribute, the repository would be stuck in state 'Cloning'
and show a debug link in the log. This commit resolves that error.
  • Loading branch information
davebx authored and jmchilton committed Aug 27, 2015
1 parent 7112532 commit b01d20b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/tool_shed/metadata/metadata_generator.py
Expand Up @@ -648,8 +648,8 @@ def generate_tool_metadata( self, tool_config, tool, metadata_dict ):
for param_name, values in ttb.inputs.iteritems():
# Handle improperly defined or strange test parameters and values.
if param_name is not None:
if values is None:
# An example is the 3rd test in http://testtoolshed.g2.bx.psu.edu/view/devteam/samtools_rmdup
if values in [ None, False ]:
# An example is the third test in http://testtoolshed.g2.bx.psu.edu/view/devteam/samtools_rmdup
# which is defined as:
# <test>
# <param name="input1" value="1.bam" ftype="bam" />
Expand Down

0 comments on commit b01d20b

Please sign in to comment.