Skip to content

Commit

Permalink
Merge pull request #5709 from scholtalbers/fix/default_ldap_role_type
Browse files Browse the repository at this point in the history
[18.01] Fix/default role type on auto created roles
  • Loading branch information
dannon committed Mar 16, 2018
2 parents ebb7be8 + be02063 commit c58ca74
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/galaxy/security/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -777,15 +777,15 @@ def get_private_user_role(self, user, auto_create=False):
return role

def get_role(self, name, type=None):
type = type or self.model.Role.types.ADMIN
type = type or self.model.Role.types.SYSTEM
# will raise exception if not found
return self.sa_session.query(self.model.Role) \
.filter(and_(self.model.Role.table.c.name == name,
self.model.Role.table.c.type == type)) \
.one()

def create_role(self, name, description, in_users, in_groups, create_group_for_role=False, type=None):
type = type or self.model.Role.types.ADMIN
type = type or self.model.Role.types.SYSTEM
role = self.model.Role(name=name, description=description, type=type)
self.sa_session.add(role)
# Create the UserRoleAssociations
Expand Down

0 comments on commit c58ca74

Please sign in to comment.