Merge pull request #5714 from jmchilton/defeated_by_selenium

Restructure and mark as flakey problematic library collection Selenium test.
galaxyproject · Mar 20, 2018 · d1489ca · d1489ca
2 parents 40e8716 + 05176da
commit d1489ca
Showing 1 changed file with 23 additions and 20 deletions.
diff --git a/test/selenium_tests/test_library_to_collections.py b/test/selenium_tests/test_library_to_collections.py
@@ -1,33 +1,18 @@
+from base.populators import flakey
+
 from .framework import (
     selenium_test,
-    SharedStateSeleniumTestCase,
+    SeleniumTestCase,
 )
 
 
-class LibraryToCollectionsTestCase(SharedStateSeleniumTestCase):
+class LibraryToCollectionsTestCase(SeleniumTestCase):
 
     requires_admin = True
 
     @selenium_test
+    @flakey
     def test_list_creation(self):
-        self.admin_login()
-        self.history_panel_create_new_with_name("new_history_for_library_list")
-        self.libraries_open_with_name(self.name)
-        self.sleep_for(self.wait_types.UX_RENDER)
-        self.components.libraries.folder.select_all.wait_for_and_click()
-        self.components.libraries.folder.add_to_history.wait_for_and_click()
-        self.screenshot("libraries_add_to_history_menu")
-        self.components.libraries.folder.add_to_history_collection.wait_for_and_click()
-        self.sleep_for(self.wait_types.UX_RENDER)
-        self.screenshot("libraries_to_collection_landing")
-        self.components.libraries.folder.import_datasets_ok_button.wait_for_and_click()
-
-        self.collection_builder_set_name("my cool list")
-        self.collection_builder_create()
-        self.home()
-        self.history_panel_wait_for_hid_ok(3)
-
-    def setup_shared_state(self):
         self.admin_login()
         self.perform_upload(self.get_filename("1.bed"))
         self.history_panel_wait_for_hid_ok(1, allowed_force_refreshes=1)
@@ -44,3 +29,21 @@ def setup_shared_state(self):
         self.libraries_dataset_import_from_history_select(["1.bed", "2.bed"])
         self.sleep_for(self.wait_types.UX_RENDER)
         self.libraries_dataset_import_from_history_click_ok()
+
+        self.home()
+
+        self.history_panel_create_new_with_name("new_history_for_library_list")
+        self.libraries_open_with_name(self.name)
+        self.sleep_for(self.wait_types.UX_RENDER)
+        self.components.libraries.folder.select_all.wait_for_and_click()
+        self.components.libraries.folder.add_to_history.wait_for_and_click()
+        self.screenshot("libraries_add_to_history_menu")
+        self.components.libraries.folder.add_to_history_collection.wait_for_and_click()
+        self.sleep_for(self.wait_types.UX_RENDER)
+        self.screenshot("libraries_to_collection_landing")
+        self.components.libraries.folder.import_datasets_ok_button.wait_for_and_click()
+
+        self.collection_builder_set_name("my cool list")
+        self.collection_builder_create()
+        self.home()
+        self.history_panel_wait_for_hid_ok(3)