Some misc cleanup in workflow-terminals.js

galaxyproject · Dec 8, 2017 · d3d6658 · d3d6658
1 parent 30bada4
commit d3d6658
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/client/galaxy/scripts/mvc/workflow/workflow-terminals.js b/client/galaxy/scripts/mvc/workflow/workflow-terminals.js
@@ -8,10 +8,10 @@ function CollectionTypeDescription(collectionType) {
 
 var NULL_COLLECTION_TYPE_DESCRIPTION = {
     isCollection: false,
-    canMatch: function(other) {
+    canMatch: function() {
         return false;
     },
-    canMapOver: function(other) {
+    canMapOver: function() {
         return false;
     },
     toString: function() {
@@ -30,13 +30,13 @@ var ANY_COLLECTION_TYPE_DESCRIPTION = {
     canMatch: function(other) {
         return NULL_COLLECTION_TYPE_DESCRIPTION !== other;
     },
-    canMapOver: function(other) {
+    canMapOver: function() {
         return false;
     },
     toString: function() {
         return "AnyCollectionType[]";
     },
-    append: function(otherCollectionType) {
+    append: function() {
         throw "Cannot append to ANY_COLLECTION_TYPE_DESCRIPTION";
     },
     equal: function(other) {
@@ -143,7 +143,9 @@ var Terminal = Backbone.Model.extend({
     },
     destroyInvalidConnections: function() {
         _.each(this.connectors, connector => {
-            connector && connector.destroyIfInvalid();
+            if (connector){
+                connector.destroyIfInvalid();
+            }
         });
     },
     setMapOver: function(val) {
@@ -317,17 +319,17 @@ var BaseInputTerminal = Terminal.extend({
             if (thisDatatype == "input") {
                 return true;
             }
-            var cat_outputs = new Array();
+            var cat_outputs = [];
             cat_outputs = cat_outputs.concat(other.datatypes);
             if (other.node.post_job_actions) {
                 for (var pja_i in other.node.post_job_actions) {
                     var pja = other.node.post_job_actions[pja_i];
                     if (
                         pja.action_type == "ChangeDatatypeAction" &&
-                        (pja.output_name == "" || pja.output_name == other.name) &&
+                        (pja.output_name === "" || pja.output_name == other.name) &&
                         pja.action_arguments
                     ) {
-                        cat_outputs.push(pja.action_arguments["newtype"]);
+                        cat_outputs.push(pja.action_arguments.newtype);
                     }
                 }
             }