Do not attach autocomplete handler if datalist is empty

galaxyproject · Jan 11, 2017 · e22b4bc · e22b4bc
1 parent a550380
commit e22b4bc
Show file tree

Hide file tree

Showing 6 changed files with 10 additions and 8 deletions.
diff --git a/client/galaxy/scripts/mvc/ui/ui-misc.js b/client/galaxy/scripts/mvc/ui/ui-misc.js
@@ -114,8 +114,10 @@ define(['utils/utils',
                     .attr( 'type', this.model.get( 'type' ) )
                     .attr( 'placeholder', this.model.get( 'placeholder' ) )
                     .css( 'color', this.model.get( 'color' ) || '' )
-                    .css( 'border-color', this.model.get( 'color' ) || '' )
-                    .autocomplete( { source : function( request, response ) { response( self.model.get( 'datalist' ) ) } } );
+                    .css( 'border-color', this.model.get( 'color' ) || '' );
+            if ( self.model.get( 'datalist' ) ) {
+                this.$el.autocomplete( { source : function( request, response ) { response( self.model.get( 'datalist' ) ) } } );
+            }
             if ( this.model.get( 'value' ) !== this.$el.val() ) {
                 this.$el.val( this.model.get( 'value' ) );
             }

diff --git a/static/maps/mvc/ui/ui-misc.js.map b/static/maps/mvc/ui/ui-misc.js.map
diff --git a/static/scripts/bundled/analysis.bundled.js b/static/scripts/bundled/analysis.bundled.js
diff --git a/static/scripts/bundled/analysis.bundled.js.map b/static/scripts/bundled/analysis.bundled.js.map
diff --git a/static/scripts/bundled/libs.bundled.js.map b/static/scripts/bundled/libs.bundled.js.map
diff --git a/static/scripts/mvc/ui/ui-misc.js b/static/scripts/mvc/ui/ui-misc.js