Merge pull request #2345 from nsoranzo/release_16.04_fix_for_2029

[16.04] Do not pollute param_dict with a non JSONifiable dict
galaxyproject · May 12, 2016 · e28d305 · e28d305
2 parents 0138136 + 8255e72
commit e28d305
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/galaxy/tools/evaluation.py b/lib/galaxy/tools/evaluation.py
@@ -224,7 +224,7 @@ def wrap_input( input_values, input ):
                     real_path = dataset.file_name
                     if real_path in input_dataset_paths:
                         wrapper_kwds[ "dataset_path" ] = input_dataset_paths[ real_path ]
-                identifier_key = param_dict[ "identifier_key" ].get( dataset, None )
+                identifier_key = identifier_key_dict.get(dataset, None)
                 if identifier_key:
                     element_identifier = param_dict.get(identifier_key, None)
                     if element_identifier:
@@ -256,7 +256,7 @@ def wrap_input( input_values, input ):
         #       tools where the inputs don't even get passed through. These
         #       tools (e.g. UCSC) should really be handled in a special way.
         if self.tool.check_values:
-            param_dict[ "identifier_key" ] = dict((v, "%s|__identifier__" % k) for k, v in input_datasets.iteritems())  # allows lookup of identifier through HDA.
+            identifier_key_dict = dict((v, "%s|__identifier__" % k) for k, v in input_datasets.iteritems())  # allows lookup of identifier through HDA.
             self.__walk_inputs( self.tool.inputs, param_dict, wrap_input )
 
     def __populate_input_dataset_wrappers(self, param_dict, input_datasets, input_dataset_paths):