Skip to content

Commit

Permalink
Fix config parameter default building in tracks.js; ideally this turn…
Browse files Browse the repository at this point in the history
…s into classes when the multiple inheritance is fixed/refactored, and we can use simple static getter/setter methods.
  • Loading branch information
dannon committed Mar 6, 2018
1 parent 4bca4a0 commit f33eee1
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion client/galaxy/scripts/viz/trackster/tracks.js
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,10 @@ var Drawable = function(view, container, obj_dict) {
this.action_icons = {};

// -- Set up drawable configuration. --
this.config = config_mod.ConfigSettingCollection.from_models_and_saved_values(this.config_params, obj_dict.prefs);
this.config = config_mod.ConfigSettingCollection.from_models_and_saved_values(
this.build_config_params(),
obj_dict.prefs
);

// If there's no saved name, use object name.
if (!this.config.get_value("name")) {
Expand Down Expand Up @@ -345,6 +348,10 @@ extend(Drawable.prototype, {
}
],

build_config_params: function() {
return this.config_params;
},

config_onchange: function() {},

init: function() {},
Expand Down

0 comments on commit f33eee1

Please sign in to comment.