[20.09] Drop trigger and update time queries #10821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jmchilton
approved these changes
Nov 28, 2020
There was a problem hiding this comment.
Thanks for fixing this, I was so worried about this and put so much effort into trying to cause these issues and really just let the project down by failing to produce the deadlocks. I'm really sorry for breaking this and really appreciate you for cleaning it up.
mvdbeek
force-pushed
the
drop_trigger_and_update_time_queries
branch
from
8d44927
to
22a2d7c
Compare
I don't think we currently filter on HDA or HDCA update_time in the UI, so this should work around the observed deadlocks, at the cost of having to re-implement a replacement on 21.01 when we'll merge galaxyproject#8441.
mvdbeek
force-pushed
the
drop_trigger_and_update_time_queries
branch
from
22a2d7c
to
33883fe
Compare
|
I've updated the PR so that we call |
mvdbeek
added
area/database
|
@mvdbeek Can I merge this forward as it is? |
|
Yes, but I do think we should probably make that a migration. |
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Apr 14, 2021
Partially revert commit 33883fe . Also: - Update `update_time` on target (i.e. `history`) table AFTER HDA/HDCA insert/update/delete - Use f-strings instead of templates - Use `CURRENT_TIMESTAMP` also in PostgreSQL (it's equivalent but standard SQL) - Code cleanups
nsoranzo
added a commit
to nsoranzo/galaxy
that referenced
this pull request
Apr 15, 2021
Partially revert commit 33883fe . Also: - Update `update_time` on target (i.e. `history`) table AFTER HDA/HDCA insert/update/delete - Use f-strings instead of templates - Use `CURRENT_TIMESTAMP` also in PostgreSQL (it's equivalent but standard SQL) - Code cleanups
mvdbeek
added a commit
that referenced
this pull request
Apr 16, 2021
Restore triggers dropped in #10821
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think we currently filter on HDA or HDCA update_time in the UI, so this should work around the observed deadlocks, at the cost of having to re-implement a replacement on 21.01 when we'll merge #8441.