Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libraries: downloading a folder with subfolders does not download subfolders #12009

Closed
davelopez opened this issue May 19, 2021 · 4 comments
Closed
Labels
area/libraries Data libraries
Milestone

Comments

@davelopez
Copy link
Contributor

issue-libs-06

Only datasets in the current folder are downloaded. I am not sure if this is the intended behavior, but, as a user, I may feel confused. If it is the intended behavior, then maybe just showing some warning when subfolders are selected will be enough.

@davelopez davelopez added the area/libraries Data libraries label May 19, 2021
@davelopez davelopez added this to the 21.05 milestone May 19, 2021
@OlegZharkov
Copy link
Contributor

I guess we need to fix this on backend. What kind of warning do you have in mind? Like a Toast or something?

@OlegZharkov
Copy link
Contributor

also this issue seems somehow to be the same one to #12007. Would it be a good idea to merge them?

@davelopez
Copy link
Contributor Author

What kind of warning do you have in mind? Like a Toast or something?

No idea, the warning will be useful only if there is some kind of technical limitation on downloading subfolders or in case it has been previously discussed and decided to not include subfolders for some reason. Maybe @martenson knows more about it?

also this issue seems somehow to be the same one to #12007. Would it be a good idea to merge them?

I think they are related, but not exactly the same, #12007 is more about the unexpected redirect when something went wrong trying to download. So it can be fixed without having to support subfolder download in case it was decided like so.

@OlegZharkov
Copy link
Contributor

fixed in #12028

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/libraries Data libraries
Projects
None yet
Development

No branches or pull requests

2 participants