Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRS import via URL #14636

Closed
fbacall opened this issue Sep 16, 2022 · 3 comments
Closed

TRS import via URL #14636

fbacall opened this issue Sep 16, 2022 · 3 comments

Comments

@fbacall
Copy link
Contributor

fbacall commented Sep 16, 2022

Hello from WorkflowHub.

Currently in WorkflowHub we provide a button on Galaxy workflow entries to run the workflow on usegalaxy.eu via a hard-coded URL:
https://usegalaxy.eu/workflows/trs_import?trs_server=workflowhub.eu&run_form=true with the ID of the workflow added on. Galaxy then imports this via WorkflowHub's TRS API.

Obviously not every Galaxy workflow will be able to run on usegalaxy.eu, and so we want to provide the option for users to specify which instance their Galaxy workflow will run on.

However, the way the TRS integration currently works is that on the WorkflowHub side we need to know which trs_server is configured for WorkflowHub on that particular Galaxy instance. This could potentially vary across different instances, and is probably beyond the average workflow submitter's knowledge.

Could the import instead directly use a TRS URL? e.g.:

https://usegalaxy.eu/workflows/trs_import?url=https://workflowhub.eu/ga4gh/trs/v2/tools/109/versions/5/GALAXY

Then Galaxy could try and import without prior knowledge about which TRS-enabled registry it is talking to.

I know there were issues in the past about differences between the Dockstore and WorkflowHub TRS implementations, not sure if they affect this.

Cheers,
Finn

@nsoranzo
Copy link
Member

@fbacall Thanks for opening the issue. I noticed that the TRS URL you suggest doesn't seem to be working, e.g.

@fbacall
Copy link
Contributor Author

fbacall commented Oct 3, 2022

https://workflowhub.eu/ga4gh/trs/v2/tools/109/versions/5/GALAXY is not a valid TRS endpoint by itself, but it is the "base" of some other endpoints:
https://workflowhub.eu/ga4gh/trs/v2/tools/109/versions/5/GALAXY/descriptor
https://workflowhub.eu/ga4gh/trs/v2/tools/109/versions/5/GALAXY/files

I'm not sure which ones you are using internally.

Maybe it makes sense to accept e.g. https://workflowhub.eu/ga4gh/trs/v2/tools/109/versions/5 as the TRS URL

fbacall added a commit to fbacall/galaxy that referenced this issue Nov 2, 2022
@fbacall fbacall mentioned this issue Nov 4, 2022
4 tasks
fbacall added a commit to fbacall/galaxy that referenced this issue Dec 5, 2022
@dannon
Copy link
Member

dannon commented Jan 25, 2023

Added in #14927

@dannon dannon closed this as completed Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants