Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output collection given unexpected name when converting datatype #15495

Closed
jennaj opened this issue Feb 2, 2023 · 2 comments
Closed

Output collection given unexpected name when converting datatype #15495

jennaj opened this issue Feb 2, 2023 · 2 comments
Assignees
Milestone

Comments

@jennaj
Copy link
Member

jennaj commented Feb 2, 2023

Describe the bug
When changing the datatype for a collection, the output collection is not named after the converter. The element datasets are named correctly after the converter.

Galaxy Version and/or server at which you observed the bug
Galaxy version 23.0.rc1, commit fdbe92986e8dd998831b3ccf11e89e8e9b1dc38d

To Reproduce
Steps to reproduce the behavior:

  1. Go to a collection of uncompressed fastqsanger reads
  2. Click on the pencil icon
  3. Click into Convert tab
  4. Choose the first option (fastqsanger -> fastqsanger.gz)
  5. Can also do the reverse on output from 4.

Expected behavior
Original collection name preserved, with the conversion method added to the end (?)

Screenshots
Screen Shot 2023-02-02 at 12 16 53 PM

Screen Shot 2023-02-02 at 12 33 53 PM

Additional context
This is a small history that can be used for testing https://usegalaxy.org/u/jen/h/test-listpaired-convert-dataype

I'm not sure what "area" this would be in

@jennaj jennaj added this to the 23.0 milestone Feb 2, 2023
@jennaj jennaj added this to To do in Collections User Experience via automation Feb 2, 2023
@jennaj
Copy link
Member Author

jennaj commented Feb 7, 2023

Update: When extracting a workflow that contains datatype conversions, the wrong converter is picked -- both in the display name and in the workflow itself (this surprised me). That conversion used fastqsanger-to-fastqsangergz, and it is at EU running 22.05. Seems related to what we discussed as a maybe-root issue for the odd output collection naming above -- eg picking the first converter in a list vs the actual converter applied.

@mvdbeek --if needs a different ticket, please lmk, maybe I misunderstood what was explained. Thanks!

https://usegalaxy.eu/u/jenj/h/test-unicycler-fastqsangergz
https://usegalaxy.eu/u/jenj/w/workflow-constructed-from-history-test-unicycler-fastqsangergz

Screen Shot 2023-02-07 at 11 56 49 AM

mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Feb 14, 2023
And give some of the converters a more consistent name.

Fixes galaxyproject#15495
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Feb 14, 2023
And give some of the converters a more consistent name.

Fixes galaxyproject#15495
@mvdbeek
Copy link
Member

mvdbeek commented Feb 15, 2023

Thanks @jennaj, fixed in #15579

@mvdbeek mvdbeek closed this as completed Feb 15, 2023
Collections User Experience automation moved this from To do to Done Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants