Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration is loaded twice in the client #16455

Closed
ElectronicBlueberry opened this issue Jul 25, 2023 · 1 comment
Closed

Configuration is loaded twice in the client #16455

ElectronicBlueberry opened this issue Jul 25, 2023 · 1 comment
Assignees

Comments

@ElectronicBlueberry
Copy link
Member

Describe the bug
The configuration is loaded once via API, and once it is included in the initial html.

Galaxy Version and/or server at which you observed the bug
Galaxy Version: dev

To Reproduce
Steps to reproduce the behavior:

  1. Open galaxy
  2. Check HTML response in network inspector, where configuration is inlined.
  3. Check network inspector to see that the configuration is additionally fetched via the API

Expected behavior
Configuration is only retrieved once

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
This was observed in #16454, as these two configurations can diverge.

@davelopez
Copy link
Contributor

We discussed this briefly in the last UI/UX meeting.

I've checked again and I think after #16514 and #16562 we are loading the configuration object only once.

In the meeting, it was mentioned that we may still want to reload the config when logging in (as it can be an admin user with extra config options) but this is working now as we reload the entire app anyway. Once we get to a full single page with 0 reloads we should make sure it's reloading it.

So I will go ahead and consider this done 🎉 please reopen if you think there is still an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants