Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate configuration store to Pinia #16514

Merged

Conversation

davelopez
Copy link
Contributor

@davelopez davelopez commented Aug 3, 2023

We need to do this sooner or later and I hope it will simplify or remove other issues in the future (like #16420 (comment))

See individual commits for more information, in summary:

  • Migrate the Galaxy configuration Vuex store to Pinia
  • Adapt the config composable to use the new Pinia store
  • Drop the ConfigProvider in all components and use the composable instead
  • Adapt relevant client tests to use Pinia and mock configuration API calls with mockFetcher

TODO

  • Drop ConfigProvider
  • Add configuration model to the API schema

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@davelopez davelopez added kind/refactoring cleanup or refactoring of existing code, no functional changes area/client labels Aug 3, 2023
@davelopez davelopez marked this pull request as ready for review August 4, 2023 10:15
@github-actions github-actions bot added this to the 23.2 milestone Aug 4, 2023
@davelopez
Copy link
Contributor Author

I think this is ready to be reviewed. I will follow up with the API schema enhancements in a different PR.

client/src/stores/configurationStore.ts Outdated Show resolved Hide resolved
client/src/composables/config.ts Outdated Show resolved Hide resolved
@ElectronicBlueberry ElectronicBlueberry merged commit a6dcb82 into galaxyproject:dev Aug 7, 2023
19 checks passed
@davelopez
Copy link
Contributor Author

Thank you so much @ElectronicBlueberry!

@davelopez davelopez deleted the migrate_config_store_pinia branch August 7, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants