Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Published datasets path is not exists /datasets/list_published #17730

Open
itisAliRH opened this issue Mar 14, 2024 · 6 comments
Open
Assignees

Comments

@itisAliRH
Copy link
Member

itisAliRH commented Mar 14, 2024

Using the masthead, Data > Datasets as an anonymous user navigates to /datasets/list_published which does not exist.

image
image

Galaxy Version and/or server at which you observed the bug
Galaxy Version: (check <galaxy_url>/api/version if you don't know)
Commit: (run git rev-parse HEAD if you run this Galaxy server)

Browser and Operating System
Operating System: Windows, Linux, macOS
Browser: Firefox, Chrome, Chrome-based, Safari

To Reproduce
Steps to reproduce the behavior:

  1. Go to from masthead, click on Data > Datasets
  2. See the error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@dannon
Copy link
Member

dannon commented Mar 14, 2024

@itisAliRH Yeah, this is the user's published datasets and shouldn't show without a user. It looks like the switching ('view in history') is also broken here, I'll take this and handle both issues.

@dannon dannon self-assigned this Mar 14, 2024
@itisAliRH
Copy link
Member Author

@dannon Thanks!

@martenson
Copy link
Member

martenson commented Mar 14, 2024

I think that URL does not exist, it should be just /list

It was likely erroneously added with the move to "Data", but there is no "published datasets" concept.

@dannon
Copy link
Member

dannon commented Mar 14, 2024

Ahh, I thought the intent here was to show public/shared datasets, hence disabling for anonymous. If it's just the big exhaustive list of datasets that's... interesting? What are the actual use cases there?

Side note, the other issue I mention above is still a problem and I'm handling that first -- it's actually the same thing that showed up recently in the 'switch to history' failure in the workflow, where you can't switch to a purged/archived history but the UI shows nothing, so I'm refactoring to use the same history switching component in both places.

@martenson
Copy link
Member

mostly searching afaik, that's how I use it

@itisAliRH itisAliRH changed the title [24.0] Published datasets is not accessible for anonymous users [24.0] Published datasets path is not exists /datasets/list_published Mar 15, 2024
@itisAliRH
Copy link
Member Author

I think that URL does not exist, it should be just /list

It was likely erroneously added with the move to "Data", but there is no "published datasets" concept.

@martenson Yes, it doesn't exist, sorry. I updated the title and description.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants