-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[24.0] Datasets list anonymous access and history link fixes. #17756
[24.0] Datasets list anonymous access and history link fixes. #17756
Conversation
…nor enhancement to accept a filter on switchtohistorylink which may be generally useful
the history column natively, keep the action language the same though when applying filter -- maybe revisit this, because the hid filtering feels weird.
{ | ||
title: _l("Datasets"), | ||
url: "/datasets/list_published", | ||
hidden: !Galaxy.user.id, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ | |
title: _l("Datasets"), | |
url: "/datasets/list_published", | |
hidden: !Galaxy.user.id, | |
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there is no grid for public datasets, this url was added erroneously during the transition under "Data" in masthead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you're right, I'll merge and open a followup
Two minor fixes for "Datasets" list/grid, fixes #17730
This form also had the same issue as was resolved in #17616, so I've standardized the history display to use that component, slightly enhanced to accept optional filters.
Anonymous users are constrained to a single history and all datasets are displayed there, so this grid is disabled (the datasets list/query backend is also not supported in the API -- if we do want to support anon we'd want to adjust that first in a larger fix).
I know this one is slated for an overhaul next cycle, but the endpoint access can be considered then along with other tweaks like thinking about the utility of the dropdown instead of a simpler mechanism for copy-to-history, etc. These could totally be draggable dataset cards or something, if we reimagine this.
How to test the changes?
(Select all options that apply)
License