[24.0] Datasets list anonymous access and history link fixes. #17756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nor enhancement to accept a filter on switchtohistorylink which may be generally useful
the history column natively, keep the action language the same though when applying filter -- maybe revisit this, because the hid filtering feels weird.
martenson
reviewed
Mar 15, 2024
Comment on lines
105
to
109
| { | ||
| title: _l("Datasets"), | ||
| url: "/datasets/list_published", | ||
| hidden: !Galaxy.user.id, | ||
| }, |
There was a problem hiding this comment.
Suggested change
| { | |
| title: _l("Datasets"), | |
| url: "/datasets/list_published", | |
| hidden: !Galaxy.user.id, | |
| }, |
There was a problem hiding this comment.
there is no grid for public datasets, this url was added erroneously during the transition under "Data" in masthead
There was a problem hiding this comment.
I think you're right, I'll merge and open a followup
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two minor fixes for "Datasets" list/grid, fixes #17730
This form also had the same issue as was resolved in #17616, so I've standardized the history display to use that component, slightly enhanced to accept optional filters.
Anonymous users are constrained to a single history and all datasets are displayed there, so this grid is disabled (the datasets list/query backend is also not supported in the API -- if we do want to support anon we'd want to adjust that first in a larger fix).
I know this one is slated for an overhaul next cycle, but the endpoint access can be considered then along with other tweaks like thinking about the utility of the dropdown instead of a simpler mechanism for copy-to-history, etc. These could totally be draggable dataset cards or something, if we reimagine this.
How to test the changes?
(Select all options that apply)
License