Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable resource requests for data_manager tools #6396

Closed
moskalenko opened this issue Jun 25, 2018 · 3 comments
Closed

Enable resource requests for data_manager tools #6396

moskalenko opened this issue Jun 25, 2018 · 3 comments

Comments

@moskalenko
Copy link
Contributor

No description provided.

@moskalenko
Copy link
Contributor Author

This is from a discussion at the galaxy admins training session. It seems that data_manager tools do not have the resource request interface hook, so it's not possible to use resources appropriate to the genome size in questions, but a sometimes very high water mark has to be set based on the largest genome as a default instead. It would be great if we could actually set cpus, memory, and time when running data managers. All our admins are real users and have SLURM allocations.

@mvdbeek
Copy link
Member

mvdbeek commented Jun 25, 2018

So we're limiting the resource selection at

if tool_id and tool_type is 'default':
to regular tools. I don't think there's a reason why we couldn't include data manager tools. We can look at that during the hackathon, or if you get a chance for testing this I'm happy to change this into if tool_id and tool_type in ('default', 'manage_data'):

@moskalenko
Copy link
Contributor Author

I just tested it. I have a bowtie2 builder job running with a custom resource request. Yay! This is great.

Thank you!

Alex

mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Jun 26, 2018
We used to restrict this to standard tools,
but there's no reason why this shouldn't work
for data manager tools. Fixes galaxyproject#6396
mvdbeek added a commit to mvdbeek/galaxy that referenced this issue Jun 26, 2018
We used to restrict this to standard tools,
but there's no reason why this shouldn't work
for data manager tools. Fixes galaxyproject#6396
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants