[20.09] Bugfix: chrome forgets scroll offset upon show/hide cycle of GTN in Galaxy webhook #10362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Content is reflown upon display changes, meaning that in chrome the iframe fails to retain it's original scroll offset. This fixes it by using visibility in place of display, thus preventing a content reflow.
|
Thanks for the fix, looks good. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the discussion in https://stackoverflow.com/questions/4582669/scroll-returns-to-default-after-displaynone-in-chrome-ie indicates that when the display property changes to none and back, that chrome reflows content and scrolls to the top by default, contrary to how firefox behaves.
So this replaces d-none with
visibility: hiddenin order to make chrome based browsers work as well as firefox.