Override some k8s runner params with destination params #10520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
reviewed
Oct 22, 2020
| @@ -227,8 +231,10 @@ def __get_k8s_job_spec_template(self, ajs): | |||
| "containers": self.__get_k8s_containers(ajs), | |||
| "priorityClassName": self.runner_params['k8s_pod_priority_class'], | |||
| "tolerations": yaml.safe_load(self.runner_params['k8s_tolerations'] or "[]"), | |||
| "affinity": yaml.safe_load(self.runner_params['k8s_affinity'] or "{}"), | |||
| "nodeSelector": yaml.safe_load(self.runner_params['k8s_node_selector'] or "{}") | |||
| "affinity": yaml.safe_load(self.__get_overridable_params(ajs.job_wrapper, | |||
There was a problem hiding this comment.
Are these things something we could test in https://github.com/mvdbeek/galaxy/blob/4842e0dbb9203209edcccfc72675c9b90e7b8b2d/test/integration/test_kubernetes_runner.py#L93 ? Set to some value that would prevent running the job and then override it in the destination ?
There was a problem hiding this comment.
Yeh I could try adding some tests
|
Thanks @almahmoud! If you ever want to get to writing tests I'm happy to help. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with galaxyproject/galaxy-helm#173 accomplishes #10481