Check Python typing for galaxy-containers and galaxy-tool-util during CI. #11000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
changed the title
jmchilton
force-pushed
the
more_types_0
branch
from
9d45437
to
9761971
Compare
jmchilton
changed the title
mvdbeek
reviewed
Dec 28, 2020
| volume_class = None | ||
| conf_defaults = { | ||
| container_type: Optional[str] = None | ||
| container_class: Optional[Type[Container]] = None |
There was a problem hiding this comment.
That's so helpful, I always struggle with what's expected here!
That's a much nicer syntax, can we replace all |
Seems like a good plan, I'm not volunteering to do it but I'll hit the merge button if someone else does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With fixes - including a much cleaner new way to add methods to namedtuples I hadn't known about.