Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow editor null/zero fixes #11265

Merged
merged 3 commits into from Feb 2, 2021

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 31, 2021

Both are type casting issues that I think can be avoided if we make our ToolParameters pydantic models.

@dannon
Copy link
Member

dannon commented Jan 31, 2021

Is this the same root issue as #9484?

If so, I'm glad for the workaround leveraging typing on the ToolParameter side, but as a heads up there are likely still other issues related to the nested encoded json. I only took a quick look with that PR and passed it off to @guerler -- maybe he has an idea if there's more of an issue here?

@mvdbeek
Copy link
Member Author

mvdbeek commented Feb 1, 2021

Yes, I put that in the commit description. I did a fairly deep dive into how we build the tool form parameter dict on the client side.

heads up there are likely still other issues related to the nested encoded json.

Yeah, for sure, it isn't even "native" json, it's just that the client casts all values to strings, which isn't optimal by a long shot. I really hope a more reasonable serialized format will fall out of vue-ifying the tool form parameters without much/any effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants