Refactor libraries API logic into LibrariesManager #11359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the dataset is not ready when calling the PATCH action resulting in the error: "This dataset is currently being used as input or output. You cannot edit metadata until the jobs have completed or you have canceled them."
- Move all the logic from LibrariesController to a manager class that will be shared with the FastAPI controller
Only the basic param adaptation is done in the controller
github-actions
bot
added
area/API
area/libraries
davelopez
force-pushed
the
refactor_libraries_api
branch
from
e8f8871
to
612b3a9
Compare
|
This PR was merged without a "kind/" label, please correct. |
jmchilton
added
the
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This dataset is currently being used as input or output. You cannot edit metadata until the jobs have completed or you have canceled them.