Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tool profile details in schema docs #11798

Merged
merged 1 commit into from Apr 8, 2021

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Apr 7, 2021

What did you do?

  • Fix tool profile details in schema docs by moving it from the attributes table to the main description.

Why did you make this change?

Per the GitHub Flavored Markdown Spec: "Block-level elements cannot be inserted in a table.", see https://github.github.com/gfm/#tables-extension-

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. GALAXY_DOCS_SKIP_SOURCE=1 make -C doc/ html
    2. xdg-open doc/build/html/dev/schema.html
    3. Check the tool profile documentation

License

Per the GitHub Flavored Markdown Spec: "Block-level elements cannot be
inserted in a table.", see
https://github.github.com/gfm/#tables-extension-
Copy link
Contributor

@bernt-matthias bernt-matthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, I was thinking about the same just today :)

@nsoranzo nsoranzo merged commit 135b135 into galaxyproject:dev Apr 8, 2021
@nsoranzo nsoranzo deleted the fix_profile_docs branch April 8, 2021 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants