Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix query parameter in /api/libraries/{id}/permissions #12047

Merged
merged 1 commit into from May 25, 2021

Conversation

davelopez
Copy link
Contributor

What did you do?

  • Rename the query parameter to q in GET /api/libraries/{id}/permissions

Why did you make this change?

The q parameter sent by the UI was being ignored as the API was expecting query when filtering roles during libraries permission management.

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Log in as Admin
    2. Go to Data Libraries
    3. Click on Manage in any folder or dataset
    4. Try to type the name of a role in any of the boxes
    5. The list should be filtering the roles as you type

License

@github-actions github-actions bot added this to the 21.09 milestone May 25, 2021
@davelopez davelopez changed the title Fix query path parameter in /api/libraries/{id}/permissions Fix query parameter in /api/libraries/{id}/permissions May 25, 2021
@mvdbeek mvdbeek merged commit 77052dd into galaxyproject:dev May 25, 2021
@davelopez davelopez deleted the fix_libraries_permission_query branch May 25, 2021 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants