Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.05] Fix history audit table row trigger #12130

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 11, 2021

The row trigger definition in postgres doesn't check for non-null values, failing on usegalaxy.eu.
I've changed the legacy paste API tests to run against postgresql 9.6, so that that branch is tested as well.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@mvdbeek mvdbeek force-pushed the legacy_postgres_testing branch 3 times, most recently from a5c2d4d to 7dd9066 Compare June 11, 2021 15:41
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@mvdbeek mvdbeek marked this pull request as ready for review June 11, 2021 15:54
@github-actions github-actions bot added this to the 21.09 milestone Jun 11, 2021
@mvdbeek mvdbeek changed the title [21.05] Run legacy API tests against legacy postgres [21.05] Fix history audit table tow trigger Jun 11, 2021
@jmchilton jmchilton merged commit e64dab3 into galaxyproject:release_21.05 Jun 11, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo deleted the legacy_postgres_testing branch June 12, 2021 18:17
@nsoranzo nsoranzo added area/database Galaxy's database or data access layer kind/bug labels Jun 12, 2021
@mvdbeek mvdbeek changed the title [21.05] Fix history audit table tow trigger [21.05] Fix history audit table row trigger Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants