Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish unittest utils for galaxy-{data,objectstore} packages. #12546

Merged
merged 8 commits into from Sep 28, 2021

Conversation

jmchilton
Copy link
Member

@jmchilton jmchilton commented Sep 24, 2021

Progress toward #8364. Cleans up dependencies and properly packages things to allow:

  • Removing symlink hacks for objectstore test helpers that allowed unit tests not properly packaged to be run with packages in objectstore and data packages.
  • We can move test_model_discovery.py into galaxy-data's unit tests since everything is properly packaged.
  • We can move test_model_store.py into galaxy-data's unit tests since everything is properly packaged - though I did some more work here to remove other dependencies as well.
  • I moved test/unit/model and test/unit/dataset_collection into test/unit/data so they are included in galaxy-data's unit test suite.

In addition to packaging more tests and cleaning up hacks, this makes it a little more clear what the interface of Galaxy's app and config that is consumed by galaxy-data functionality (e.g. model stores).

How to test the changes?

  • This is a refactoring of components with existing test coverage.

License

@jmchilton jmchilton added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Sep 24, 2021
@github-actions github-actions bot added this to the 22.01 milestone Sep 24, 2021
@jmchilton jmchilton changed the title Establish unittest utils for galaxy-data package. [WIP] Establish unittest utils for galaxy-data package. Sep 24, 2021
@jdavcs
Copy link
Member

jdavcs commented Sep 24, 2021

A very enthusiastic +1 for minimal galaxy mock!

@jmchilton jmchilton changed the title [WIP] Establish unittest utils for galaxy-data package. [WIP] Establish unittest utils for galaxy-{data,objectstore} packages. Sep 24, 2021
@jmchilton jmchilton mentioned this pull request Sep 24, 2021
3 tasks
@jmchilton jmchilton changed the title [WIP] Establish unittest utils for galaxy-{data,objectstore} packages. Establish unittest utils for galaxy-{data,objectstore} packages. Sep 24, 2021
Co-authored-by: Dannon <dannon.baker@gmail.com>
@jmchilton jmchilton merged commit ee381a5 into galaxyproject:dev Sep 28, 2021
@jmchilton jmchilton deleted the galaxy_data_test_dag branch September 28, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/packaging area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants