New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish unittest utils for galaxy-{data,objectstore} packages. #12546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
added
the
kind/refactoring
cleanup or refactoring of existing code, no functional changes
label
Sep 24, 2021
jmchilton
changed the title
Establish unittest utils for galaxy-data package.
[WIP] Establish unittest utils for galaxy-data package.
Sep 24, 2021
jmchilton
force-pushed
the
galaxy_data_test_dag
branch
from
September 24, 2021 14:39
6f379dd
to
88ff89f
Compare
A very enthusiastic +1 for minimal galaxy mock! |
jmchilton
force-pushed
the
galaxy_data_test_dag
branch
from
September 24, 2021 15:10
88ff89f
to
6166e8c
Compare
jmchilton
changed the title
[WIP] Establish unittest utils for galaxy-data package.
[WIP] Establish unittest utils for galaxy-{data,objectstore} packages.
Sep 24, 2021
3 tasks
jmchilton
force-pushed
the
galaxy_data_test_dag
branch
from
September 24, 2021 16:01
1d85a1d
to
e7b4f1f
Compare
Progress toward galaxyproject#8364. Cleans up dependency into a proper DAG so we can move for instance test_model_discovery.py into galaxy-data's unittests.
…t_model_copy.py in galaxy-data.
… part of galaxy-data tests.
jmchilton
force-pushed
the
galaxy_data_test_dag
branch
from
September 24, 2021 16:17
e7b4f1f
to
84785b7
Compare
3 tasks
jmchilton
changed the title
[WIP] Establish unittest utils for galaxy-{data,objectstore} packages.
Establish unittest utils for galaxy-{data,objectstore} packages.
Sep 24, 2021
3 tasks
dannon
reviewed
Sep 28, 2021
dannon
approved these changes
Sep 28, 2021
Co-authored-by: Dannon <dannon.baker@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/packaging
area/testing
kind/refactoring
cleanup or refactoring of existing code, no functional changes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress toward #8364. Cleans up dependencies and properly packages things to allow:
In addition to packaging more tests and cleaning up hacks, this makes it a little more clear what the interface of Galaxy's app and config that is consumed by galaxy-data functionality (e.g. model stores).
How to test the changes?
License