[21.09] Sync reset mapping with Node component map-over state #12598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
fix_outputs_21.09.002
branch
from
f83df52
to
7e46857
Compare
mvdbeek
approved these changes
Sep 30, 2021
guerler
force-pushed
the
fix_outputs_21.09.002
branch
from
74f2273
to
dad0e7b
Compare
|
@mvdbeek added a qunit test case for this issue. Waiting for all PR tests to pass now. Thanks a lot for the review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #12032. New outputs rely on a predefined
node.mapOverstate defined in thesetMapOverhelper. When resetting themapOverstate thenode.mapOverstate is not updated. Hence newly created terminals run into an outdated state which in some cases leads to issues. The handling of thenode.mapOverstate has been moved to theterminalmodule since it is only used there.