Core, CORS: allow (non-preflighted) CORS requests by echoing back the…

[carlfeberhard]

… origin header if the requesting client is allowed

Fixes #1029

[hexylena]

@galaxybot test this

[hexylena]

Looks like a failed TS test

Error - <type 'exceptions.AttributeError'>: 'Configuration' object has no attribute 'allowed_origin_hostnames'
URL: http://localhost:8397/
File '/galaxy/lib/galaxy/web/framework/middleware/error.py', line 151 in __call__
  app_iter = self.application(environ, sr_checker)
File '/galaxy/.venv/local/lib/python2.7/site-packages/paste/recursive.py', line 85 in __call__
  return self.application(environ, start_response)
File '/galaxy/.venv/local/lib/python2.7/site-packages/paste/httpexceptions.py', line 640 in __call__
  return self.application(environ, start_response)
File '/galaxy/lib/galaxy/web/framework/base.py', line 127 in __call__
  return self.handle_request( environ, start_response )
File '/galaxy/lib/galaxy/web/framework/base.py', line 157 in handle_request
  self.set_cors_headers( trans )
File '/galaxy/lib/galaxy/web/framework/base.py', line 219 in set_cors_headers
  if not trans.app.config.allowed_origin_hostnames:
AttributeError: 'Configuration' object has no attribute 'allowed_origin_hostnames'

[carlfeberhard]

Not sure what's going on with Travis here. Can't reproduce this locally with tox either. /shrug

[hexylena]

Yeah, dunno about travis either, but I'm a bit nervous to break the build for everyone else.
You have my 👍, but I'd like a second pair of eyes merging this.

[hexylena]

@martenson maybe? You're brave :)

[jmchilton]

I imagine the Travis problem is this line in Configuration.

        self.new_file_path = resolve_path( kwargs.get( "new_file_path", "database/tmp" ), self.root )
        tempfile.tempdir = self.new_file_path

Invoking a Configuration object changes global state of the Python interpreter for all the other unit tests run in. I'd suggest a flag to configuration to disable that for unit tests.

[carlfeberhard]

@jmchilton Interesting. Thanks for the info - I'll check it out

[carlfeberhard]

That was it. Thanks, @jmchilton

[jmchilton]

Awesome sauce, glad that worked out. Thanks @carlfeberhard!