Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collections #134

Merged
merged 10 commits into from Apr 20, 2015
Merged

Collections #134

merged 10 commits into from Apr 20, 2015

Conversation

carlfeberhard
Copy link
Contributor

This PR allows the user more flexibility and editing power when creating list and pair collections.

For the list creator:

  • a modal is opened, any non-valid elements are displayed in a dismissable alert, help is displayed behind it (in the style of the list of pairs creator), and possible elements for the final collection are shown in the center.
  • Elements can be dragged and dropped to re-order them.
  • Duplicate names are mangled (as OSX ('name (1)') and the user can further click the name to edit it.
  • The user can discard any elements they previously selected by clicking a 'Discard' button.
  • The user can begin again (as if they just opened the dialog) by clicking 'start over'.
  • The final collection name is now editable (and autofocuses on modal startup).

For the pair creator (for the most part, the same as the list creator changes):

  • Forward and reverse elements are 'swap'-able instead of dragging to re-order.
  • No discarding, 'start over', or renaming (not needed for this simpler collection structure).

@jmchilton
Copy link
Member

Had tried this branch out pre-PR - really fantastic stuff @carlfeberhard! 👍

@dannon
Copy link
Member

dannon commented Apr 20, 2015

+1

dannon added a commit that referenced this pull request Apr 20, 2015
@dannon dannon merged commit a2ba53f into galaxyproject:dev Apr 20, 2015
@carlfeberhard carlfeberhard deleted the collections branch July 31, 2015 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants