[21.01] Initial fix for quay.io repo query issue #13468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes not getting a full list of images in a repo. Without this fix some container images are not resolvable.
jdavcs
reviewed
Mar 2, 2022
jdavcs
approved these changes
Mar 2, 2022
Co-authored-by: Sergey Golitsynskiy <sgolitsynskiy@gmail.com>
dannon
approved these changes
Mar 2, 2022
|
Do we know an example repo that was affected by this ? We could add this to the tests then. |
|
On anvil, we were able to replicate with fastqc and multiqc. |
mvdbeek
commented
Mar 2, 2022
nsoranzo
reviewed
Mar 2, 2022
Comment on lines
64
to
65
| if resolution_cache is not None and cache_key in resolution_cache: | ||
| repo_names = resolution_cache.get(cache_key) |
There was a problem hiding this comment.
Shouldn't the cache have different repo_names for different namespaces?
There was a problem hiding this comment.
I think so, this would be a problem if we we're using more than one namespace, but so far it's only biocontainers.
There was a problem hiding this comment.
Yep, added to #13460 for tracking.
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes not getting a full list of images in a repo. Without this fix some container images are not resolvable.
I understand there's more to be done, but this is a major fix we should get out ASAP.
How to test the changes?
(Select all options that apply)
License