Drop redundant legacy API endpoints #13582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/API
area/dependencies
area/libraries
|
It seems there are some legacy endpoints that bypass the FastAPI ones. The |
|
Oh, nice catch, yes, we can probably drop the middleware |
5 tasks
I can't find a trace of this being used in the client. We should re-implement it as a ASGI middleware if we've identified a need for it, but I don't love how this makes the call a potentially very long blocking call. To fetch many items in batch we might be better off using Server Sent Events, which can trickle out intermediate updates.
and drop require_admin, users can have permission to update libraries (see also dropped legacy endpoint that did not enfore this).
mvdbeek
force-pushed
the
drop_redundant_routes
branch
2 times, most recently
from
70b2901
to
cfa51ef
Compare
The ConfigProvider isn't strictly necessary, passing the store to mounted component would have been sufficient to make `getGalaxyInstance().config` work.
mvdbeek
force-pushed
the
drop_redundant_routes
branch
from
cfa51ef
to
1896215
Compare
mvdbeek
force-pushed
the
drop_redundant_routes
branch
from
692eb3c
to
df3d438
Compare
davelopez
approved these changes
Mar 22, 2022
|
This PR was merged without a "kind/" label, please correct. |
nsoranzo
added
the
kind/refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #13579 to identify what needs to be dropped from buildapp.py.
How to test the changes?
(Select all options that apply)
License