Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix two bugs in mulled container building #13925

Merged

Conversation

bernt-matthias
Copy link
Contributor

respecting conda channels on disk: follow up on #13755

  • CondaInDockerContext needs the list of channels and not the joined str
  • get_file_from_recipe should use local data

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

respecting conda channels on disk: follow up on galaxyproject#13755

- CondaInDockerContext needs the list of channels and not the joined str
- get_file_from_recipe should use local data
@bernt-matthias bernt-matthias marked this pull request as ready for review May 18, 2022 23:38
@nsoranzo nsoranzo merged commit f12ee5c into galaxyproject:dev May 19, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@bernt-matthias bernt-matthias deleted the fix-mulled-respect-conda-channels branch November 12, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants