Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tpv rule module name and constrain version #14072

Merged
merged 1 commit into from Jun 15, 2022

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Jun 14, 2022

This PR does some major refactoring prior to release to make naming more consistent.
Also constrains TPV version to <2 in case of future breaking changes.

License

@nuwang nuwang added this to the 22.05 milestone Jun 14, 2022
@nuwang nuwang requested a review from afgane June 14, 2022 19:06
@nuwang nuwang marked this pull request as ready for review June 15, 2022 12:14
Copy link
Contributor

@afgane afgane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the upgrade changes and all checked out.

@afgane afgane merged commit 9ad1270 into galaxyproject:dev Jun 15, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@afgane afgane added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Jun 15, 2022
@nuwang nuwang deleted the pin_tpv_and_fix_module branch June 15, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependencies area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants