New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine Convert and Datatypes forms #14159
Combine Convert and Datatypes forms #14159
Conversation
Looks good to me, we should unify the tab headers such that it only shows one icon. Maybe just |
I remember that at least one converter has an additional dataset input. Is this supported? |
@bernt-matthias Thanks for your inquiry. This PR only relocates existing fields and existing forms. There should be no functional changes that occur - no removal of existing fields and no additional fields. However, I was unaware there could be "multiple fields" on the "Convert" tab. This would be a good case scenario to include as part of my development work. Would you be able to provide a bit more information (or screenshot) of the "multiple fields" case that you mention? |
Maybe I was wrong. This would be the only converter having two inputs:
But according to the comment (written myself :)) and the tests only a single data set needs to be added. Wondering if the mechanism might fail, e.g. if there is a bgzip file in the history .. would the converter use this one instead of the autogenerated one? |
4c50a34
to
2180a8d
Compare
This PR was merged without a "kind/" label, please correct. |
Issue #14027
How to test the changes?
(Select all options that apply)
License