Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Convert and Datatypes forms #14159

Merged
merged 4 commits into from Aug 9, 2022

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Jun 22, 2022

Issue #14027

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@guerler
Copy link
Contributor

guerler commented Jun 22, 2022

Looks good to me, we should unify the tab headers such that it only shows one icon. Maybe just Convert.

@bernt-matthias
Copy link
Contributor

I remember that at least one converter has an additional dataset input. Is this supported?

@hujambo-dunia
Copy link
Contributor Author

@bernt-matthias Thanks for your inquiry. This PR only relocates existing fields and existing forms. There should be no functional changes that occur - no removal of existing fields and no additional fields.

However, I was unaware there could be "multiple fields" on the "Convert" tab. This would be a good case scenario to include as part of my development work. Would you be able to provide a bit more information (or screenshot) of the "multiple fields" case that you mention?

@bernt-matthias
Copy link
Contributor

Maybe I was wrong. This would be the only converter having two inputs:

<param format="bgzip" name="bgzip" type="data" label="BGZIP file"/>

But according to the comment (written myself :)) and the tests only a single data set needs to be added.

Wondering if the mechanism might fail, e.g. if there is a bgzip file in the history .. would the converter use this one instead of the autogenerated one?

@hujambo-dunia hujambo-dunia marked this pull request as ready for review June 29, 2022 20:28
@github-actions github-actions bot added this to the 22.09 milestone Jun 29, 2022
@mvdbeek mvdbeek changed the title combined Convert and Datatypes forms Combine Convert and Datatypes forms Jul 1, 2022
@dannon dannon merged commit 8e9e5fc into galaxyproject:dev Aug 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 9, 2022

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants