Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05] Check for app_name and link_name before unquoting #14291

Merged
merged 1 commit into from Jul 11, 2022

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jul 11, 2022

Should fix
https://sentry.galaxyproject.org/share/issue/f20a1d47fab04ca8bca7a657d81fb568/:

AttributeError: 'NoneType' object has no attribute 'replace'
  File "/cvmfs/main.galaxyproject.org/venv/lib/python3.8/site-packages/paste/recursive.py", line 85, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/middleware/statsd.py", line 29, in __call__
    req = self.application(environ, start_response)
  File "/cvmfs/main.galaxyproject.org/venv/lib/python3.8/site-packages/paste/httpexceptions.py", line 640, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 159, in __call__
    return self.handle_request(environ, start_response)
  File "galaxy/web/framework/base.py", line 244, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/web/framework/decorators.py", line 138, in set_nocache_headers
    return func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/controllers/dataset.py", line 738, in display_application
    link_name = unquote_plus(link_name)
  File "urllib/parse.py", line 777, in unquote_plus
    string = string.replace('+', ' ')

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

Should fix
https://sentry.galaxyproject.org/share/issue/f20a1d47fab04ca8bca7a657d81fb568/:
```
AttributeError: 'NoneType' object has no attribute 'replace'
  File "/cvmfs/main.galaxyproject.org/venv/lib/python3.8/site-packages/paste/recursive.py", line 85, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/middleware/statsd.py", line 29, in __call__
    req = self.application(environ, start_response)
  File "/cvmfs/main.galaxyproject.org/venv/lib/python3.8/site-packages/paste/httpexceptions.py", line 640, in __call__
    return self.application(environ, start_response)
  File "galaxy/web/framework/base.py", line 159, in __call__
    return self.handle_request(environ, start_response)
  File "galaxy/web/framework/base.py", line 244, in handle_request
    body = method(trans, **kwargs)
  File "galaxy/web/framework/decorators.py", line 138, in set_nocache_headers
    return func(self, trans, *args, **kwargs)
  File "galaxy/webapps/galaxy/controllers/dataset.py", line 738, in display_application
    link_name = unquote_plus(link_name)
  File "urllib/parse.py", line 777, in unquote_plus
    string = string.replace('+', ' ')
```
@mvdbeek mvdbeek changed the title Check for app_name and link_name before unquoting [22.05] Check for app_name and link_name before unquoting Jul 11, 2022
@github-actions github-actions bot added this to the 22.09 milestone Jul 11, 2022
@nsoranzo nsoranzo modified the milestones: 22.09, 22.05 Jul 11, 2022
@mvdbeek mvdbeek merged commit a96cec9 into galaxyproject:release_22.05 Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants