[22.05] Fix cache image singularity resolver if path contains uppercase chars #14431

mvdbeek · 2022-08-11T11:04:14Z

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these contributions under Galaxy's current license.
I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

lib/galaxy/tool_util/deps/requirements.py

Much nicer! Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>

mvdbeek added the kind/bug label Aug 11, 2022

github-actions bot added area/testing area/tool-dependencies area/tool-framework labels Aug 11, 2022

github-actions bot added this to the 22.09 milestone Aug 11, 2022

Fix cache image singularity resolver if path contains uppercase chars

0560e43

Fixes galaxyproject#14425

mvdbeek force-pushed the cached_image_path_identifier_fix branch 3 times, most recently from 6c61824 to 0560e43 Compare August 11, 2022 11:59

nsoranzo reviewed Aug 11, 2022

View reviewed changes

lib/galaxy/tool_util/deps/requirements.py Outdated Show resolved Hide resolved

Use os.sep.join

b4a8c06

Much nicer! Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>

nsoranzo approved these changes Aug 11, 2022

View reviewed changes

mvdbeek merged commit 9dd74fc into galaxyproject:release_22.05 Aug 12, 2022

mvdbeek mentioned this pull request Aug 12, 2022

Singulary container local path (cache_directory) needs to be in lowercase #14425

Closed

mvdbeek modified the milestones: 22.09, 22.05 Aug 18, 2022

bernt-matthias mentioned this pull request Jan 9, 2024

Allow for upper case container tags #17254

Merged

4 tasks