Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22.05] Fix data_range_{min,max} parsing #14456

Merged
merged 4 commits into from Aug 17, 2022
Merged

[22.05] Fix data_range_{min,max} parsing #14456

merged 4 commits into from Aug 17, 2022

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Aug 15, 2022 •
edited by nsoranzo

All datetime values established via our sqlalchemy models don't include tzinfo.
Fixes #14094 (comment)

In general this is a bad thing, we should definitely be honoring timezone info, but the rest of the app just assumes UTC, so this will
work.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@mvdbeek
Fix data_range_{min,max} parsing
414156a 
All datetime values established via our sqlalchemy models don't include `tzinfo`.
Fixes
galaxyproject#14094 (comment).

In general this is a bad thing, we should definitely be honoring
timezone info, but the rest of the app just assumes UTC, so this will
work.
@github-actions github-actions bot added this to the 22.09 milestone Aug 15, 2022
mvdbeek and others added 2 commits August 16, 2022 13:11
@mvdbeek @nsoranzo
Convert to UTC instead of stripping timezone
cd76fef 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@mvdbeek
Add unit test
b0d9cff 
That was meant to go into the first commit ...
@mvdbeek @nsoranzo
Include timezone testing
973d077 
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@nsoranzo nsoranzo modified the milestones: 22.09, 22.05 Aug 17, 2022
@nsoranzo nsoranzo merged commit 9915a6e into galaxyproject:release_22.05 Aug 17, 2022
@nsoranzo nsoranzo deleted the drop_tzinfo_when_parsing_datetime branch August 17, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nsoranzo nsoranzo nsoranzo approved these changes

Assignees
No one assigned
Labels
area/API kind/bug
Projects
None yet
Milestone
22.05
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mvdbeek @nsoranzo