Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.05]Fix absolute path generation util #14531

Merged
merged 1 commit into from Aug 30, 2022

Conversation

dannon
Copy link
Member

@dannon dannon commented Aug 29, 2022

Just shifts slashcleanup to only the composed portion to avoid deduplicating '/' in protocol.

Issue reported by @nekrut on matrix; to test this use the dataset 'copy' function and note that before you'd get a url like:

https:/usegalaxy.org/api/datasets/f9cad7b01a4721358cfdfdaa2fac173c/display?to_ext=tabular

(note the single slash in https:/)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Try copying a dataset url with the link icon

License

@dannon dannon marked this pull request as ready for review August 29, 2022 14:51
@dannon dannon changed the title Fix absolute path generation util [22.05]Fix absolute path generation util Aug 29, 2022
@dannon dannon changed the base branch from dev to release_22.05 August 29, 2022 14:52
@github-actions github-actions bot added this to the 22.09 milestone Aug 29, 2022
@mvdbeek mvdbeek merged commit c39323f into galaxyproject:release_22.05 Aug 30, 2022
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants