Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option for post logout redirect url #14570

Merged
merged 2 commits into from Sep 7, 2022

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Sep 3, 2022

Currently our post log out url is fixed to /root/login?is_login_redirect=true, and this constant is used in the client and the backend. This PR suggests to add the post logout url to the Galaxy configuration and handle it consistently in both cases. It also optionally enables admins to customize the logout urls.

Additionally this PR contains a fix to properly route the context-menu new tab handling.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@guerler guerler added kind/enhancement area/configuration Galaxy's configuration system labels Sep 3, 2022
@guerler guerler added this to the 22.09 milestone Sep 3, 2022
@guerler guerler force-pushed the logout_url branch 2 times, most recently from db5d00e to 8313d71 Compare September 4, 2022 20:17
@guerler guerler marked this pull request as ready for review September 5, 2022 20:50
@dannon dannon merged commit c7a275b into galaxyproject:dev Sep 7, 2022
@guerler guerler deleted the logout_url branch September 7, 2022 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration Galaxy's configuration system kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants