Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add scroll shadow on the right and left sides #14665

Merged
merged 1 commit into from Oct 10, 2022
Merged

add scroll shadow on the right and left sides #14665

merged 1 commit into from Oct 10, 2022

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Sep 21, 2022 •
edited by nsoranzo

Related #14600: the backdrop shadow in scroll list

2022-09-21.13-04-01.mp4

Known issue

Any background colour of elements is shown on top of these shadows

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@github-actions github-actions bot added this to the 22.09 milestone Sep 21, 2022
martenson
martenson approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works nice and improves the interface perception

@martenson martenson merged commit 79d3ce3 into galaxyproject:dev Oct 10, 2022
@martenson
Copy link
Member

thanks @itisAliRH !

@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@martenson martenson mentioned this pull request Oct 10, 2022
Open
@itisAliRH itisAliRH deleted the scroll-shadow-in-multiple-view branch October 11, 2022 13:11
@dannon dannon mentioned this pull request Oct 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martenson martenson martenson approved these changes

@guerler guerler Awaiting requested review from guerler

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@itisAliRH @martenson @nsoranzo