Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and speed up converter testing #14891

Merged
merged 7 commits into from Nov 3, 2022

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Oct 31, 2022

(Please replace this header with a description of your pull request. Please include BOTH what you did and why you made the changes. The "why" may simply be citing a relevant Galaxy issue.)
(If fixing a bug, please add any relevant error or traceback)
(For UI components, it is recommended to include screenshots or screencasts)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 1, 2022

Looks like bigwig outputs failed ... because the len files were not mounted into the container ?!

@mvdbeek mvdbeek marked this pull request as ready for review November 1, 2022 11:15
@github-actions github-actions bot added this to the 23.1 milestone Nov 1, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
@mvdbeek mvdbeek changed the title Explicitly set test data location for converter tests Simplify and speed up converter testing Nov 2, 2022
@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 2, 2022

Do we want to do biocontainers testing or conda ? Both should work now.

@nsoranzo
Copy link
Member

nsoranzo commented Nov 3, 2022

Do we want to do biocontainers testing or conda ? Both should work now.

No strong preference from me.

@mvdbeek
Copy link
Member Author

mvdbeek commented Nov 3, 2022

I guess there's something to be said for some conda testing, given the "environment rot". This is ready from my side.

@jmchilton jmchilton merged commit 5a28b24 into galaxyproject:dev Nov 3, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants