Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install involucro when resolvers are instantiated #15130

Merged
merged 3 commits into from Dec 7, 2022

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Dec 7, 2022

i.e. at Galaxy startup. Should fix #15112 .

Also:

  • Fix resolved default value of tool_dependency_dir and involucro_path config options, which caused involucro to be created in the Galaxy root directory during some tests.
  • Update minikube-setup-action and use more recent k8s version. The older minikube/k8s fail to launch under Ubuntu 22.04, which is being deployed on GitHub action workers.
  • Type annotations
  • Code refactorings

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

i.e. at Galaxy startup.

Also:
- Type annotations
- Code refactorings
The older minikube/k8s fail to launch under Ubuntu 22.04, which
is being deployed on GitHub action workers:
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much @nsoranzo!

@mvdbeek mvdbeek merged commit fdc59a3 into galaxyproject:dev Dec 7, 2022
@nsoranzo nsoranzo deleted the fix_test_build_mulled branch December 7, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flakey integration tests
2 participants