Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes to YAML export of OpenAPI schema. #15187

Merged
merged 1 commit into from Dec 13, 2022
Merged

Small fixes to YAML export of OpenAPI schema. #15187

merged 1 commit into from Dec 13, 2022

Conversation

jmchilton
Copy link
Member

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Switch _schema.json to _schema.yaml in the Makefile and watch it fail without this fix.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

mvdbeek
mvdbeek approved these changes Dec 12, 2022
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mvdbeek
Copy link
Member

mvdbeek commented Dec 13, 2022

Since I also want to build on this I'll merge this, despite the draft, hope that's ok.

@mvdbeek mvdbeek marked this pull request as ready for review December 13, 2022 10:55
@github-actions github-actions bot added this to the 23.0 milestone Dec 13, 2022
@mvdbeek mvdbeek merged commit 842c500 into galaxyproject:dev Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/API kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmchilton @mvdbeek