Tweak OpenAPI schema #15189
Merged
Tweak OpenAPI schema #15189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmchilton
reviewed
Dec 12, 2022
| @@ -511,22 +511,22 @@ def download_dataset_collection( | |||
| @router.post( | |||
| "/api/histories/{history_id}/contents/dataset_collections/{id}/prepare_download", | |||
| summary="Prepare an short term storage object that the collection will be downloaded to.", | |||
| include_in_schema=False, | |||
| ) | |||
| @router.post( | |||
There was a problem hiding this comment.
I have an alternate fix for this... in a branch that will be very conflicted 😆. hackathons
|
Fixed a relevant API test failure based on the parameter name change. Thanks for disambiguation fixes - they are very nice! |
mvdbeek
force-pushed
the
openapi_python_client
branch
from
2ee2642
to
ba30405
Compare
|
I resolved the conflict and dropped the typo fix, since you've fixed them all in #15195 :) |
|
Ekkk - sorry about the conflicting typo fix. |
|
No worrries, doing it all at once is great! |
mvdbeek
force-pushed
the
openapi_python_client
branch
from
4357095
to
22962f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to test the changes?
(Select all options that apply)
License