New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize workflow editor state handling #15268
Modernize workflow editor state handling #15268
Conversation
b3d8fbf
to
4c369f4
Compare
8cf6cd6
to
be2ae61
Compare
I've opted to split out the workflow output button from the output visibilty, that fixes an open bug I'll dig out later. I know this is a little controversial, let me know if y'all have better ideas. I will leave in the pan indicator and monaco for the reviewers, that's easy enough to drop out once I have a 👍 |
8531bee
to
6cd3f7c
Compare
It's a little bit less of the DOM manipulation in JS. Should hopefully make it easier to clean up after itself.
Follows upstream change: vueuse/vueuse#2054
The key was to move canvas-background into canvas content.
7ba1635
to
e3e151c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fantastic step forward. I noticed a few minor things we can follow up on during the freeze, but this is working very well for me and I'd like to go ahead and get it in. Really great work @mvdbeek
There's a whole lot this PR is doing (sorry about that, I'm contemplating pulling out smaller parts), but these are the main points:
This should be a good start to add new workflow editor features, like selecting and manipulating multiple steps, editing multiple workflows, displaying invalid connections, displaying conditional steps and connections and more.
TODO:
@vueuse/core
How to test the changes?
(Select all options that apply)
License