Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabular dataset display component #15285

Merged
merged 22 commits into from Jan 17, 2023
Merged

Tabular dataset display component #15285

merged 22 commits into from Jan 17, 2023

Conversation

dannon
Copy link
Member

@dannon dannon commented Jan 8, 2023 •
edited

Screenshot:

image

check replaceChildren tweak -- likely need to address other consumers, but this is a good change.

This initial implementation intentionally keeps the overly flexible row handling in place (variable column numbers, diverging from spec, basically rendering anything you throw at it). We should follow up with more explicit handling for particular types when data can be assured to be clean -- this will allow for significant performance improvements.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Click eye for various tabular datasets, observe display.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon
Use replaceChildren instead of empty() for appending. TODO: append do…
526ccec 
…esn't append, it empties and appends?
@dannon
Stub out createNewTabularView, cut over for testing.
cfef1e2
@dannon
Tinker with useDataset composable ideas, basic table?
34397eb
@dannon
Incremental progress; swap to bs-vue based simple table for consisten…
c2c361f 
…cy in display
@dannon
Update imports for upstream changes
dbb94f6
@dannon
Set up chunk fetching for new data
e3364ae
@dannon
Minor fixes.
75febc8
@dannon
Add window scroll trigger
827cf18
@dannon
Fix tabularData row types
c4dbd42
@dannon
Refactoring
9912618
@dannon
Add basic column header handling
44de428
@dannon
Transplant row massaging logic for special cases in place (adapted) f…
21bc55c 
…or now; need to revisit this.
@dannon
Adjust column handling
42c7b4f
@dannon
Support even less structured tabbed data...
e2b0196
@dannon
Relax quote parsing -- this supports gff handling without the extra c…
4803bea 
…orner case massaging
@dannon
Cut over to new tabular display everywhere.
96452fb
@dannon
EOF handling, minor commentary.
3426c32
@dannon
Handle column alignment based on column type
409a9ec
@dannon dannon marked this pull request as ready for review January 9, 2023 16:17
@github-actions github-actions bot added this to the 23.0 milestone Jan 9, 2023
@guerler guerler added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Jan 9, 2023
guerler
guerler approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@guerler guerler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good step forward. Thank you!

@dannon dannon merged commit 3f8a88c into galaxyproject:dev Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guerler guerler guerler approved these changes

@ElectronicBlueberry ElectronicBlueberry ElectronicBlueberry approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dannon @guerler @jarrah42 @ElectronicBlueberry