-
Notifications
You must be signed in to change notification settings - Fork 972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement conditional workflow editor UI, optional connections, track and display invalid connections #15328
Merged
dannon
merged 10 commits into
galaxyproject:dev
from
mvdbeek:state_fixes_workflow_editor
Jan 20, 2023
Merged
Implement conditional workflow editor UI, optional connections, track and display invalid connections #15328
dannon
merged 10 commits into
galaxyproject:dev
from
mvdbeek:state_fixes_workflow_editor
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b6a722
to
55ef77b
Compare
55ef77b
to
2f25ff7
Compare
2f25ff7
to
41d82e5
Compare
2e909a4
to
d3f5540
Compare
That one selenium test error is unrelated |
dannon
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! We've discussed a few iterations of improvements out of band but this is a great addition as-is, let's get it in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/API
area/database
Galaxy's database or data access layer
area/dependencies
area/testing/api
area/testing
area/tool-framework
area/UI-UX
area/workflows
highlight/power-user
Included at bottom of user-facing release notes (please use either this or highlight, but not both)
kind/feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds editor support for conditional workflow steps:
This also changes how we deal with invalid connections (like when you make a step conditional, or change a steps's output datatype, or when the tool is not installed ...)
This makes it so much easier to replace invalid connections without missing something:
Fixes #13527.
It'd also be the basis for transitively changing e.g the input collection type ... if we can just show that a connection is now invalid we can let the user evaluate if they really want to do it.
How to test the changes?
(Select all options that apply)
License