Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conditional workflow editor UI, optional connections, track and display invalid connections #15328

Merged
merged 10 commits into from
Jan 20, 2023

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jan 18, 2023

This adds editor support for conditional workflow steps:

creating a conditional workflow step

This also changes how we deal with invalid connections (like when you make a step conditional, or change a steps's output datatype, or when the tool is not installed ...)
This makes it so much easier to replace invalid connections without missing something:

Screenshot 2023-01-18 at 11 57 39

Fixes #13527.

It'd also be the basis for transitively changing e.g the input collection type ... if we can just show that a connection is now invalid we can let the user evaluate if they really want to do it.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@mvdbeek mvdbeek changed the title Track and display invalid connections Implement conditional workflow editor UI, optional connections, track and display invalid connections Jan 20, 2023
@mvdbeek mvdbeek marked this pull request as ready for review January 20, 2023 14:13
@github-actions github-actions bot added this to the 23.0 milestone Jan 20, 2023
@mvdbeek mvdbeek added the highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) label Jan 20, 2023
@mvdbeek
Copy link
Member Author

mvdbeek commented Jan 20, 2023

That one selenium test error is unrelated

Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! We've discussed a few iterations of improvements out of band but this is a great addition as-is, let's get it in.

@dannon dannon merged commit a37b772 into galaxyproject:dev Jan 20, 2023
@nsoranzo nsoranzo deleted the state_fixes_workflow_editor branch January 20, 2023 18:09
@galaxyproject galaxyproject deleted a comment from github-actions bot Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/database Galaxy's database or data access layer area/dependencies area/testing/api area/testing area/tool-framework area/UI-UX area/workflows highlight/power-user Included at bottom of user-facing release notes (please use either this or highlight, but not both) kind/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to load workflow issues while editing
3 participants