Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Adding more directive to the Invalid Input tooltip #15406

Merged
merged 1 commit into from Jan 26, 2023
Merged

[23.0] Adding more directive to the Invalid Input tooltip #15406

merged 1 commit into from Jan 26, 2023

Conversation

assuntad23
Copy link
Contributor

@assuntad23 assuntad23 commented Jan 25, 2023 •
edited

In response to #15374, I've added a directive to the invalid input tooltip that says that the user must disconnect the input to move forward.

Screencast.from.01-25-2023.12.45.21.PM.webm

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Create Workflow with conditionals
    2. Change the tool to not use conditional
    3. Notice change in the tooltip that tells user how to fix error

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@assuntad23 assuntad23 added this to the 23.0 milestone Jan 25, 2023
@mvdbeek mvdbeek merged commit 437f0e2 into galaxyproject:release_23.0 Jan 26, 2023
@mvdbeek
Copy link
Member

mvdbeek commented Jan 26, 2023

Thank you @assuntad23!

@assuntad23 assuntad23 mentioned this pull request Jan 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/UI-UX area/workflows kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@assuntad23 @mvdbeek