Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[23.0] Add support for Python 3.11 #15487

Merged
merged 2 commits into from Feb 2, 2023
Merged

[23.0] Add support for Python 3.11 #15487

merged 2 commits into from Feb 2, 2023

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Feb 1, 2023

  • Update Python dependencies that didn't have a cp311 wheel: h5py and psycopg2-binary.
  • For packages for which there is no recent version that works on all Python versions supported by Galaxy (numpy and scipy), replace old requirement with multiple Python-version-specific requirements.
  • Replace 2 Enums with Literals to fix mypy errors on Python 3.11 .

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@nsoranzo nsoranzo added this to the 23.0 milestone Feb 1, 2023
@nsoranzo
Copy link
Member Author

nsoranzo commented Feb 2, 2023

Test failures unrelated.

@nsoranzo nsoranzo added the area/python3 Specific to Python 3 label Feb 2, 2023
@nsoranzo
Add support for Python 3.11
4ca163b 
- Update Python dependencies that didn't have a cp311 wheel: h5py and
  psycopg2-binary.
- For packages for which there is no recent version that works on all
  Python versions supported by Galaxy (numpy and scipy), replace old
  requirement with multiple Python-version-specific requirements.
@nsoranzo
Replace 2 Enums with Literals
a7ddf89 
Fix the following mypy errors on Python 3.11:

```
$ tox -e py311-mypy
py311-mypy: commands[0]> mypy test lib
lib/galaxy/schema/schema.py:1099: error: Incompatible types in assignment (expression has type "str", base class "Enum" defined the type as "Callable[[Enum], str]")  [assignment]
        name = "name"
               ^~~~~~
lib/galaxy/schema/schema.py:2722: error: Incompatible types in assignment (expression has type "str", base class "Enum" defined the type as "Callable[[Enum], str]")  [assignment]
        name = "name"
               ^~~~~~
```
mvdbeek
mvdbeek approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@mvdbeek mvdbeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks a lot @nsoranzo!!!

@mvdbeek mvdbeek merged commit 0c336c3 into galaxyproject:release_23.0 Feb 2, 2023
@nsoranzo nsoranzo deleted the release_23.0_python3.11 branch February 2, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdbeek mvdbeek mvdbeek approved these changes

Assignees
No one assigned
Labels
area/API area/dependencies area/packaging area/python3 Specific to Python 3 area/UI-UX kind/bug
Projects
None yet
Milestone
23.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nsoranzo @mvdbeek